-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2023.10.0 #401
Release v2023.10.0 #401
Conversation
versions = dict( | ||
re.findall(r"^\s*(ResStock|ComStock|BuildStockBatch)_Version\s*=\s*'(.+)'", f.read(), re.MULTILINE) | ||
) | ||
BuildStockBatch_Version = semver.Version.parse(versions['BuildStockBatch']) | ||
if bsb_version < BuildStockBatch_Version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerket Do you need to also semver.Version.parse()
on bsb_version
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, you can compare version objects to strings and it will automatically convert.
@joseph-robertson It looks like the errors from CI are now coming from the buildstock.rb version check in ResStock. |
Not sure what we want to do here. Is it possible to except these errors for certain versions of ResStock? |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1f5c4bf |
Release Checklist
release_vYYYY.MM.X
branch for your release changes.__version__.py
to reflect the new release version.docs/changelog/changelog_dev.rst
todocs/changelog/changelog_YYYY_MM_X.rst
.changelog_YYYY_MM_X.rst
docs/changelog/index.rst