Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2023.10.0 #401

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Release v2023.10.0 #401

merged 7 commits into from
Oct 24, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Oct 17, 2023

Release Checklist

  • Make a release_vYYYY.MM.X branch for your release changes.
  • Update __version__.py to reflect the new release version.
  • Create changelog for the new version.
    • Copy docs/changelog/changelog_dev.rst to docs/changelog/changelog_YYYY_MM_X.rst.
    • Remove the example change, update version names, and release date in changelog_YYYY_MM_X.rst
    • Clear out the dev changelog for the next version.
    • Add a link to TOC in docs/changelog/index.rst
  • Write a migration guide for the new version. Link from TOC.
  • Build docs locally and ensure they render correctly.
  • Verify integration tests are working on CI
  • On Eagle
    • Download the new default singularity image.
    • Build a new environment
    • Run a test batch
  • Tag release, make release in GitHub
  • Update RTD to include latest release
  • Build environment for release on Eagle

@nmerket nmerket self-assigned this Oct 18, 2023
versions = dict(
re.findall(r"^\s*(ResStock|ComStock|BuildStockBatch)_Version\s*=\s*'(.+)'", f.read(), re.MULTILINE)
)
BuildStockBatch_Version = semver.Version.parse(versions['BuildStockBatch'])
if bsb_version < BuildStockBatch_Version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerket Do you need to also semver.Version.parse() on bsb_version here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, you can compare version objects to strings and it will automatically convert.

@nmerket
Copy link
Member Author

nmerket commented Oct 18, 2023

@joseph-robertson It looks like the errors from CI are now coming from the buildstock.rb version check in ResStock.

@joseph-robertson
Copy link
Contributor

@joseph-robertson It looks like the errors from CI are now coming from the buildstock.rb version check in ResStock.

Not sure what we want to do here. Is it possible to except these errors for certain versions of ResStock?

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

File Coverage
All files 86%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 1f5c4bf

@nmerket nmerket merged commit 29958ca into develop Oct 24, 2023
6 checks passed
@nmerket nmerket deleted the release_v2023.10.0 branch October 24, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants