Small refactor to simplify adding a GCP implementation #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lathanh
approved these changes
Nov 3, 2023
|
It seems our CI is failing because it's expecting PRs from within this repo and some of the actions don't have the correct permissions. Don't worry about that too much for now. I'll see if I can sort out a way to make that work before merging it down. |
|
@nmerket Are you okay with merging this now? Or do you want to work on getting the checks to pass first? |
|
Yeah, I can merge this. It looks like the issues we're seeing is a known issue with PRs from a fork for one of the actions we're using. It's not that important and it looks like all tests are passing otherwise. However, If you have any suggestions on how to make github happy with this, I'm all ears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move a few things out of aws.py that will be reused in a GCP implementation, to keep future changes simpler.