Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: convert UpgradeCosts measure to ModelMeasure #455

Closed
wants to merge 5 commits into from

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jun 7, 2024

Pull Request Description

UpgradeCosts has been changed from a reporting measure to a model measure (and ReportHPXMLOutput has been removed). Therefore, we need a few changes to the residential workflow generator. We also need to continue to support older versions of UpgradeCosts/ReportHPXMLOutput as reporting measures.

(Related to NREL/resstock#1253.)

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@joseph-robertson joseph-robertson self-assigned this Jun 7, 2024
@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Jun 10, 2024

Tests are hanging on GHA for some reason... but I can verify locally that tests changed in this PR (i.e., test_residential_hpxml) still run successfully.

@joseph-robertson joseph-robertson marked this pull request as ready for review June 10, 2024 19:52
@joseph-robertson joseph-robertson changed the title ResStock-HPXML: change order of ReportHPXMLOutput and UpgradeCosts ResStock-HPXML: convert UpgradeCosts measure to ModelMeasure Jun 10, 2024
@joseph-robertson joseph-robertson deleted the res-reporting branch July 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant