-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to python 3.11 #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively we could drop support for python 3.8 altogether and add support for 3.12. I'm able to run on 3.12, but it gives some warnings.
I considered doing that but remembered your reservation about dropping 3.8 because some part of BSB AWS needing to run inside the openstudio container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we're dropping support for 3.9 and 3.10? It's officially supported until October 2025 and 2026, respectively.
Should also have a changelog entry.
setup.py
Outdated
python_requires=">=3.8", | ||
python_requires=">=3.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work with Python 3.13 yet? Should we make that explicit here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't. I added that check.
Co-authored-by: Noel Merket <noel.merket@nrel.gov>
Will not work in NREL network/computer.
Pull Request Description
Black stopped supporting python 3.8: psf/black#4452. We can do the same as well, and make BSB use python 3.11 with support for 3.12. This allows us to use features introduced in later python version such as the union operator on dict and fine-grained error location.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.