Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions to optional dependencies #1035

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Nov 21, 2024

This small pull request does two things:

  1. Removes the pin on autoyaml put in place in Fix docs #1034 now that the issue is resolved (see YAML compose error in 1.1.2 Jakski/sphinxcontrib-autoyaml#26)

-- Confirm docs build locally

  1. Adds versions to optional dependencies as a partial guard against future major version jumps (wouldn't have helped here but good practice!)

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 22, 2024

python 3.8 doesn't support the recent major version of pre-commit, I think my preference is to drop 3.8 since it's end of life: https://devguide.python.org/versions/, but we could also give the pre-commit dependency more options,

@misi9170
Copy link
Collaborator

My feeling is that dropping 3.8 is appropriate since it is end of life, but @rafmudaf also suggested we could have a more dedicated discussion. Is there also an option to remove tests for 3.8, but not explicitly require that users are at python >= 3.9? What is the usual protocol on that?

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 22, 2024

I'm ok with that approach, but it seems it could only be transitory status, where we allow 3.8 but can't guarantee tests pass

@misi9170
Copy link
Collaborator

Right. Perhaps that's not good form---perhaps we should strictly require 3.9, I'm not sure.

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 22, 2024

that's my vote, since it's end of life it seems that is the right move,

@misi9170
Copy link
Collaborator

I've now opened a PR that removes support for python version 3.8 #1042 . Once we are happy with that and it is merged, we can merge develop back into this branch and tests should pass.

misi9170
misi9170 approved these changes Dec 2, 2024
@misi9170 misi9170 merged commit cf05538 into NREL:develop Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants