Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components - Map #13

Merged
merged 13 commits into from
May 27, 2022
Merged

Components - Map #13

merged 13 commits into from
May 27, 2022

Conversation

ppinchuk
Copy link
Collaborator

reV and ReEDS now use the same map component

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #13 (4aa546a) into main (e389f6d) will increase coverage by 0.35%.
The diff coverage is 23.88%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   45.88%   46.23%   +0.35%     
==========================================
  Files          37       37              
  Lines        2744     2656      -88     
  Branches      443      440       -3     
==========================================
- Hits         1259     1228      -31     
+ Misses       1470     1413      -57     
  Partials       15       15              
Flag Coverage Δ
unittests 46.23% <23.88%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reView/pages/reeds/model.py 66.66% <ø> (+26.66%) ⬆️
reView/pages/reeds/view.py 100.00% <ø> (ø)
reView/pages/scenario/model.py 18.85% <0.00%> (ø)
reView/pages/scenario/view.py 100.00% <ø> (ø)
reView/pages/reeds/controller/callbacks.py 52.50% <18.18%> (-6.33%) ⬇️
reView/components/map.py 16.48% <21.95%> (-1.26%) ⬇️
reView/pages/scenario/controller/callbacks.py 38.42% <35.71%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e389f6d...4aa546a. Read the comment docs.

@ppinchuk ppinchuk merged commit d55e3a3 into main May 27, 2022
@ppinchuk ppinchuk deleted the pp/components_map branch May 27, 2022 20:37
@ppinchuk ppinchuk linked an issue May 27, 2022 that may be closed by this pull request
@ppinchuk ppinchuk added this to the reV and ReEDS pages use the same map milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReEDS Buildout Page Features
2 participants