Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest OS-HPXML #1124

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Latest OS-HPXML #1124

merged 6 commits into from
Aug 23, 2023

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Aug 21, 2023

Pull Request Description

Pulls in:

Checked means that something in resstock was changed or updated as a result of pulling in.

Questions:

  • Should we re-think when/where validation on the HPXML file is performed? Currently we skip validation from HPXMLtoOpenStudio. Instead, we validate both before and after applying defaults from BuildExistingModel and ApplyUpgrade. (We apply defaults from ApplyUpgrade so that home.xml looks similar to the home.xml produced when there are no upgrades.) Validation therefore happens 2 times for a home with no upgrade, and 4 times for a home with an upgrade. Should we switch back to having HPXMLtoOpenStudio do the validation? Then we would only be validating 2 times (when no upgrade) or 3 times (when upgrade).

Checklist

Not all may apply:

0f80b93a49 Merge pull request #1467 from NREL/build-res-validation
4de9a0a6f3 Another remove.
7fb1dfc97e Remove checks for bad duct defaults.
8dbaf08de7 Merge branch 'master' into build-res-validation
7b8cd4df3e Update the changelog. [ci skip]
9b51701f0e Clean up test file.
31931317b8 Catch errors for certain duct surface area arg combos.
1d968719b9 Add test for demonstrating invalid defaults.
213e506092 Must write defaulted hpxml_doc before validating.
8212560c97 Update apply_validation arg in build test file.
5429fbd508 Change behavior of apply_defaults and apply_validation.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 0f80b93a49bf6111f1b4a27ea9b066ba62f3d5d2
@joseph-robertson joseph-robertson added this to the ResStock v3.2.0 milestone Aug 21, 2023
@joseph-robertson joseph-robertson self-assigned this Aug 21, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review August 22, 2023 23:09
@joseph-robertson joseph-robertson merged commit cc0133b into develop Aug 23, 2023
7 checks passed
@joseph-robertson joseph-robertson deleted the latest-os-hpxml branch August 23, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant