Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run run_analysis in parallel #1230

Merged
merged 17 commits into from
May 16, 2024
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Apr 15, 2024

Pull Request Description

Up-to-date copy of #1131.
Closes #1130.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

jmarrec and others added 5 commits September 7, 2023 16:45
…f it's already up to date

Compute a checksum by checking file name, file modified time, and file size. It checksums match, you are guaranteed to have a resstock/lib folder that's fully up to date.
…csv_path instead of expecting it at lib/housing_characteristics/buildstock.csv
@joseph-robertson joseph-robertson added this to the ResStock v3.3.0 milestone Apr 15, 2024
@joseph-robertson joseph-robertson self-assigned this Apr 15, 2024
@@ -477,11 +485,49 @@ def run_workflow(yml, in_threads, measures_only, debug_arg, overwrite, building_
return true
end

def create_lib_folder(lib_dir, resources_dir, housing_characteristics_dir)
def checksum_dir_content(directory_path)
files = Dir.glob('**/*', base: directory_path).select { |fn| File.file?(File.join(directory_path, fn)) }
Copy link
Contributor Author

@joseph-robertson joseph-robertson Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarrec I had to prepend directory_path here so that the size of the files array isn't zero. Not sure how your testing/application worked without this fixed?

@joseph-robertson joseph-robertson marked this pull request as ready for review April 25, 2024 22:46
@joseph-robertson joseph-robertson merged commit 947de90 into develop May 16, 2024
7 checks passed
@joseph-robertson joseph-robertson deleted the parallel_resstock_develop2 branch May 16, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run resstock in parallel
2 participants