Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates duct effective R-values; allows duct shape inputs #1234

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Apr 24, 2024

Pull Request Description

Test NREL/OpenStudio-HPXML#1691.

Conclusion: accepting the new defaults has a pretty minimal impact on results.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

…d6dc437

b63eed6dc437 Merge pull request #1691 from NREL/duct_shape
ac2415602bd9 Latest results.
1532d17b68a9 Shift a few more runs.
eadb929401f0 Latest results.
82edf31ad08e Add sample files, some more tests.
a57b3bef9ff6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into duct_shape
f243e9275ca7 Latest results.
0a8c8aba153d Bump tolerance a bit.
373355001b0c First pass.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: b63eed6dc4373817c9eb41bf1b1d54ef14de6873
@joseph-robertson joseph-robertson marked this pull request as ready for review April 25, 2024 18:25
@joseph-robertson joseph-robertson merged commit 40a0a4b into latest-os-hpxml Apr 25, 2024
7 checks passed
@joseph-robertson joseph-robertson deleted the duct_shape branch April 25, 2024 18:26
@joseph-robertson joseph-robertson mentioned this pull request Apr 25, 2024
14 tasks
@joseph-robertson joseph-robertson added this to the ResStock v3.3.0 milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant