Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hot Water Fixtures tsv #1265

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Update Hot Water Fixtures tsv #1265

merged 12 commits into from
Sep 24, 2024

Conversation

lixiliu
Copy link
Contributor

@lixiliu lixiliu commented Jul 8, 2024

Pull Request Description

Resolves: #1236
Companion ResStock-Estimation PR: https://github.com/NREL/resstock-estimation/pull/420

Mean-shifted distribution from 0.8 to 1.0
Specifically, the previous distribution is specified as a lognormal distribution with a transformed mean of 0.8 and a stdev 0.2.
New distribution is tabulated directly from mean-shifted input data (with mean=1.0 and a stdev ~ 0.236).
image

Checklist

Not all may apply:

@lixiliu lixiliu self-assigned this Jul 8, 2024
@lixiliu lixiliu requested a review from afontani July 8, 2024 23:17
@lixiliu lixiliu requested a review from jmaguire1 July 10, 2024 19:32
Copy link
Contributor

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I definitely still want to test this with a ResStock run, but I also need to pull in a branch of the latest OS-HPXML to do this. I'll talk to Joe about if we can do the run with these as open PRs.

@jmaguire1
Copy link
Contributor

Results with these updates:

image

This is MUCH better than we used to be. If we wanted to get to exactly 1.0, I think we could shift the mean in this distribution to be 3% lower (the average across all usage levels in this 30k sample, which should be big enough to be representative). That said, I'd be fine with this as is, compared to the huge boost in hot water use we were doing. I suspect this will have a pretty minimal effect on energy use, maybe on the edges of some HPWH cases you'll end up with more element usage, but overall being slightly higher than 100% on average seems like a pretty minimal difference.

@shorowit
Copy link
Contributor

Hmm, what is the possible explanation for why things are off by 2-5%? If the distribution has a mean of 1.0 and we have enough samples, it seems like we should be closer.

Would it make sense to do a quick run where we only use the 100% Usage option and see if that matches better? That could help isolate whether the discrepancy is caused by the energy model or the distribution.

@jmaguire1
Copy link
Contributor

jmaguire1 commented Sep 4, 2024

@shorowit: The mean of the % distributions is also 1.02 (as in the average multiplier is coming out to 1.02, not 1.00), so I'm pretty confident if we use all 100% multipliers we'll get 1.00 exactly, and this is down to the distribution of multipliers. It seems like this is either not enough samples (unlikely) or the distribution is just slightly off when we generated them. I can look at tweaking the bin weights to get this to average exactly 1.00 if we think it's worth the effort. I can tweak the distributions and we can do another 30k run if we think that's worth doing.

@afontani
Copy link
Contributor

afontani commented Sep 4, 2024

@jmaguire1 : to double-check the shifting of the distribution to make sure it was done correctly and correspond to the ~2% discrepancy.

@jmaguire1
Copy link
Contributor

So now that this is fixed in resstock-estimation (see https://github.com/NREL/resstock-estimation/pull/420) and tested with a 30k sample, I think this is good?

Here's what I get on my sample for an average multiplier so this is documented in the PR:
image

@afontani afontani merged commit 0c2ce88 into develop Sep 24, 2024
@afontani afontani deleted the ll/hot_water_fixtures_mult branch September 24, 2024 13:31
@joseph-robertson joseph-robertson added this to the ResStock v3.4.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot water usage seems low
5 participants