Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: include additional binaries in the fmu increasing portability #137

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ENH: include additional binaries in the fmu increasing portability #137

wants to merge 2 commits into from

Conversation

HenningScheufler
Copy link
Contributor

This feature enables better portability by including additional binaries in the binaries folder

libpythonfmu-export.so now includes the ORIGIN RUNPATH so it will automatically link to binaries on the FMU.

markaren
markaren reviewed Sep 27, 2021
View reviewed changes
pythonfmu/pythonfmu-export/src/CMakeLists.txt
@@ -17,6 +17,9 @@ set(sources
pythonfmu/PySlaveInstance.cpp
)

SET (CMAKE_SHARED_LINKER_FLAGS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be UNIX only?

@markaren
Copy link
Member

markaren commented Sep 27, 2021 •
edited
Loading

I wonder if it isn't just as easy to manually add the binaries into the archive? With that said, adding this does not exclude the former.

@HenningScheufler HenningScheufler marked this pull request as draft September 27, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markaren markaren markaren left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenningScheufler @markaren