-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ws for updating vote count and active connections #184
Conversation
I have come to think of NTNUI/vote and NTNUI/opptak and regular pull requests. Perhaps we should remove the approval for PRs to dev (and maybe just commit directly) in these projects, and do a proper review from dev to main? |
Maybe, I am going to set up the production environment for vote soon, so we can consider it then. I also think it will be more difficult to understand what you are approving when it's consisting of 3-4+ pull requests
|
Jumping between projects to review, I think it's a somewhat challenging already to understand what the different conventions are for each project. We should consider including a How to test in PR templates/descriptions, such as this one 😺 |
9dab1b1
to
2b927f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super system 🤩 Nice job! Will test in dev as agreed upon 🤝
Closes #159
Using WebSockets for updating vote count and active participants in real-time.
When researching this issue I also noticed the basic plan in Azure is restricted to 350 concurrent connections.
For production the standard plan is therefore recommend.
https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits
Live count updated for every logged in organizer: