Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ws for updating vote count and active connections #184

Merged
merged 8 commits into from
Sep 6, 2023

Conversation

edalholt
Copy link
Member

@edalholt edalholt commented Aug 8, 2023

Closes #159

Using WebSockets for updating vote count and active participants in real-time.

When researching this issue I also noticed the basic plan in Azure is restricted to 350 concurrent connections.
For production the standard plan is therefore recommend.
https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits

Live count updated for every logged in organizer:
Skjermbilde 2023-08-08 kl  18 14 05

@edalholt edalholt self-assigned this Aug 8, 2023
@edalholt edalholt changed the title feat: websockets organizer feat: ws for updating vote count and active connections Aug 8, 2023
@Xtrah
Copy link
Member

Xtrah commented Aug 9, 2023

I have come to think of NTNUI/vote and NTNUI/opptak and regular pull requests. Perhaps we should remove the approval for PRs to dev (and maybe just commit directly) in these projects, and do a proper review from dev to main?

@edalholt
Copy link
Member Author

edalholt commented Aug 9, 2023

Maybe, I am going to set up the production environment for vote soon, so we can consider it then. I also think it will be more difficult to understand what you are approving when it's consisting of 3-4+ pull requests

I have come to think of NTNUI/vote and NTNUI/opptak and regular pull requests. Perhaps we should remove the approval for PRs to dev (and maybe just commit directly) in these projects, and do a proper review from dev to main?

@Xtrah
Copy link
Member

Xtrah commented Aug 9, 2023

Jumping between projects to review, I think it's a somewhat challenging already to understand what the different conventions are for each project. We should consider including a How to test in PR templates/descriptions, such as this one 😺

@edalholt edalholt changed the base branch from main to dev August 14, 2023 12:54
Copy link

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super system 🤩 Nice job! Will test in dev as agreed upon 🤝

frontend/src/components/EditAssembly.tsx Outdated Show resolved Hide resolved
frontend/src/components/EditAssembly.tsx Outdated Show resolved Hide resolved
frontend/src/components/EditAssembly.tsx Show resolved Hide resolved
@edalholt edalholt merged commit 3dcc4b4 into dev Sep 6, 2023
5 checks passed
@edalholt edalholt deleted the feat/websockets-organizer branch September 6, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live count of how many users has voted
3 participants