feat: initially get votation data from websocket #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalholt
added
Frontend
Backend
Functionality
enhancement
edalholt
changed the title
eivindkopperud
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before all participants were notified when a new votation is started. Then they did a fetch for getting the votation data. Thus all participants are triggering a database read. Now this votation data is sent together with the update notification from the same database read. This makes the application feel faster and uses fewer resources.
The previous endpoint for fetching the votation is still used if the user refreshes the page.
No fectch (Unless reload) - DEMO:
Skjermopptak.2023-08-21.kl.22.46.41.mov