Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess call to wp_enqueue_script() #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove excess call to wp_enqueue_script() #18

wants to merge 1 commit into from

Conversation

evansolomon
Copy link

jQuery is already declared as a dependency, so there's no need to explicitly enqueue it on its own.

@evansolomon
Remove excess call to wp_enqueue_script()
4e8f907 
jQuery is already declared as a dependency, so there's no need to explicitly enqueue it on its own.
kadamwhite
kadamwhite approved these changes Dec 17, 2023
View reviewed changes
Copy link

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. If another plugin for some reason dequeue'd the verite-timeline-embed script, jQuery wouldn't be properly dequeue'd with it — this is admittedly an edge case, but I agree the suggested change is more technically correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadamwhite kadamwhite kadamwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evansolomon @kadamwhite