Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress leaks from inside dlopen #5245

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

szkarpinski
Copy link
Collaborator

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

We dlopen things but not dlclose them, so some internal dlopen structures get leaked. This was suppressed in #4521, but some of the functions listed there got inlined, resulting in new false positives.

In this PR I add dlopen to the suppressions list to avoid further false-positives

Additional information:

Affected modules and functionalities:

Sanitizer CI runs

Key points relevant for the review:

Maybe suppressing dlopen is too wide?

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
@awolant awolant self-assigned this Dec 14, 2023
@szkarpinski
Copy link
Collaborator Author

@mzient pointed out that dlopen calls globals constructors, so if there's any leak in there it'll get suppressed. So I guess suppressing dlopen was a bad idea.

@szkarpinski
Copy link
Collaborator Author

@awolant @banasraf I changed (62256ef) the suppressions to be more precise, dlopen was too broad and might suppress true leaks. I'll run sanitizer build in a moment to see if this still helps.

@JanuszL JanuszL assigned JanuszL and unassigned banasraf Dec 18, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11568412]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11573073]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11573073]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11603250]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11603250]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [12053951]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [12053951]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [12053951]: BUILD PASSED

@szkarpinski
Copy link
Collaborator Author

After a long rollercoaster of trying different ways to suppress things I came back to the original solution of just suppressing dlopen itself and the CI is finally passing 🎉 . @JanuszL @awolant is this OK?

@JanuszL
Copy link
Contributor

JanuszL commented Jan 18, 2024

I think we can proceed that way.

@szkarpinski szkarpinski merged commit 4800336 into NVIDIA:main Jan 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants