-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support checkpointing in PaddlePaddle iterator #5279
Conversation
2a7c651
to
08d4099
Compare
08d4099
to
ac4d178
Compare
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
ac4d178
to
59a8495
Compare
dali/test/python/checkpointing/test_dali_checkpointing_fw_iterators.py
Dismissed
Show dismissed
Hide dismissed
!build |
CI MESSAGE: [12664006]: BUILD STARTED |
CI MESSAGE: [12664006]: BUILD FAILED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
!build |
CI MESSAGE: [12676712]: BUILD STARTED |
CI MESSAGE: [12676712]: BUILD FAILED |
CI MESSAGE: [12676712]: BUILD PASSED |
@banasraf @klecki I've successfully rebased on #5298, but with one non-trivial change. It turned out that When Paddle iterator was added (#1371), there was no Can I ask for re-approval for that? |
Category:
New feature (non-breaking change which adds functionality)
Description:
Checkpointing support was already implemented in
BaseIterator
in #5061, but wasn't tested for frameworks other than Pytorch. In this PR I add tests for PaddlePaddle Iterator and fix a problem with ES checkpointing. This work is very similar to #5282When an iterator is created and there's no data in the external source, DALI reports "no data in pipeline" error. The problem is that if we checkpoint after the last iteration and restore from such checkpoint, there's no data in the external source but it's not an error. In this PR I silence this error if we're restoring from checkpoint. Exactly the same change was made in #5213 and #5282
Additional information:
Affected modules and functionalities:
PaddlePaddle Iterator
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3751