Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null arg input access #5622

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Sep 5, 2024

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

ClearWorkspacePayload can iterate over argument inputs in an incomplete workspace, resulting, in some cases, in a NULL pointer dereference. This PR adds an ArgumentInputPtr function which can be used to safely determine whether the input is null and it also adds assertions to normal access functions.

Additional information:

Affected modules and functionalities:

New executor (use pointer instead of reference and check whether it's null).
Workspace (asserts, one new function).

Key points relevant for the review:

Tests:

Covered by future PR #5528.
Regressions covered by executor2/*test

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18163763]: BUILD STARTED

@JanuszL JanuszL self-assigned this Sep 5, 2024
@awolant awolant self-assigned this Sep 5, 2024
@mzient mzient merged commit b3a1889 into NVIDIA:main Sep 5, 2024
5 of 6 checks passed
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18163763]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants