Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
ClearWorkspacePayload
can iterate over argument inputs in an incomplete workspace, resulting, in some cases, in a NULL pointer dereference. This PR adds an ArgumentInputPtr function which can be used to safely determine whether the input is null and it also adds assertions to normal access functions.Additional information:
Affected modules and functionalities:
New executor (use pointer instead of reference and check whether it's null).
Workspace (asserts, one new function).
Key points relevant for the review:
Tests:
Covered by future PR #5528.
Regressions covered by executor2/*test
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A