Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin libprotobuf and protobuf to 5.24 which works with python 3.8-3.12 in conda #5643

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 20, 2024

  • libprotobuf and protobuf 5.25 seems to be incompatible with python 3.8,
    so pin it to 5.24

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • libprotobuf and protobuf 5.25 seems to be incompatible with python 3.8,
    so pin it to 5.24

Additional information:

Affected modules and functionalities:

  • dali_python_bindings recipe

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • conda build process
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18586081]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18586081]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18680882]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18680882]: BUILD FAILED

… in conda

- libprotobuf and protobuf 5.25 seems to be incompatible with python 3.8,
  so pin it to 5.24

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL JanuszL changed the title Make protobuf a build time dependency for DALI python bindings in conda Pin libprotobuf and protobuf to 5.24 which works with python 3.8-3.12 in conda Sep 24, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18686531]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18686531]: BUILD PASSED

@JanuszL JanuszL marked this pull request as ready for review September 24, 2024 15:47
@awolant awolant assigned awolant and unassigned banasraf Sep 24, 2024
@JanuszL JanuszL merged commit 92ea873 into NVIDIA:main Sep 24, 2024
6 checks passed
@JanuszL JanuszL deleted the fix_conda_proto branch September 24, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants