Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return in()->toInlineString() in LoadStoreOp::toInlineString #3378

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

return in()->toInlineString() in LoadStoreOp::toInlineString #3378

wants to merge 6 commits into from
+6 −1

Conversation

liqiangxl
Copy link
Collaborator

@liqiangxl liqiangxl commented Nov 8, 2024 •
edited
Loading

Fix #3360
Return in()->toInlineString() in LoadStoreOp::toInlineString
to ensure we get a string that only consists of symbols that have no defining expressions.

@liqiangxl
Copy link
Collaborator Author

!test

@liqiangxl liqiangxl changed the title print scalar output in LoadStoreOp::toInlineString return in()->toInlineString() in LoadStoreOp::toInlineString Nov 9, 2024
@liqiangxl
Copy link
Collaborator Author

!build

@liqiangxl liqiangxl requested a review from naoyam November 9, 2024 00:55
naoyam
naoyam approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liqiangxl liqiangxl marked this pull request as ready for review November 9, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoyam naoyam naoyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoadStoreOp::toInlineString should not assume it's a tensor op
2 participants
@liqiangxl @naoyam