Add Multiple Model Classification example #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
sarahyurick
commented
Jul 30, 2024
tutorials/distributed_data_classification/multiple_quality_models.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
sarahyurick
commented
Aug 7, 2024
tutorials/distributed_data_classification/multiple_quality_models.ipynb
Outdated
Show resolved
Hide resolved
sarahyurick
commented
Nov 7, 2024
Comment on lines
152
to
153
| "classifier_0 = QualityClassifier(\n", | ||
| " model_path=quality_model_path,\n", |
There was a problem hiding this comment.
model_path has been removed since this PR was opened. See https://github.com/sarahyurick/NeMo-Curator/blob/quality_ensemble/nemo_curator/modules/distributed_data_classifier.py for the original QualityClassifier implementation.
sarahyurick
changed the title
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
|
Hi @VibhuJawa this is ready for review. Just depends on rapidsai/crossfit#99. |
VibhuJawa
requested changes
Nov 10, 2024
There was a problem hiding this comment.
The notebook looks like a great example to me, we should just probably keep this as a tutorial for folks to follow for now.
Thanks for working on this again @sarahyurick
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
…o-Curator into quality_ensemble
VibhuJawa
reviewed
Nov 12, 2024
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
|
@VibhuJawa thanks for your comments! I think I have addressed everything. |
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
VibhuJawa
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Thanks for pushing on this @sarahyurick , this tutorial looks great to me.
Its good to merge from my end
vinay-raman
pushed a commit
to vinay-raman/NeMo-Curator
that referenced
this pull request
Nov 26, 2024
* add notebook Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * continue debugging Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add working example Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * run black Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * minor updates from main Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * update readme, add pin Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * test remove cython Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * re-add cython Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * try using setuptools_scm Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add fetch-depth Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add fetch-tags Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * move everything to tutorials Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * remove _init_weights Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * remove py file and add it to ipynb Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Vinay Raman <viraman@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
cc @VibhuJawa