Disable checkpoint conversion inside AutoResume #10645
Open
+239
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hemildesai
force-pushed
the
hemil/revamp-finetuning-recipes
branch
from
4fc4d89
to
8f92c11
Compare
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
hemildesai
force-pushed
the
hemil/revamp-finetuning-recipes
branch
from
756d6f3
to
a896007
Compare
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: cuichenx <cuichenx@users.noreply.github.com>
hemildesai
commented
Oct 2, 2024
nemo/lightning/megatron_parallel.py
Outdated
| ) | ||
| # Mcore DistributedDataParallel has to be called with grad. Normally this call is redundant, but for | ||
| # PEFT with num_sanity_val_steps > 0 this is necessary. | ||
| with torch.enable_grad(): |
There was a problem hiding this comment.
Should there be a check to only use this if it's PEFT?
There was a problem hiding this comment.
thanks for the comment, revised!
Signed-off-by: Chen Cui <chcui@nvidia.com>
|
@hemildesai this is great, have you run a two node job to test resuming from an HF checkpoint? What's the process for the user? I imagine this will be a frequent request so I want to make sure it's as frictionless as possible. I did a quick pass but will revisit later today. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Checkpoint conversion is not feasible inside AutoResume as it is not reliable in multi process/multi node scenarios. This update disables checkpoint conversion inside AutoResume and forces users to use a NeMo based checkpoint.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information