Adding NeMo 2.0 T5 finetuning (on Squad dataset) #10716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com>
Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com>
huvunvidia
force-pushed
the
huvu/t5_nemo2.0_finetune
branch
from
9d32c13
to
eeac5aa
Compare
huvunvidia
force-pushed
the
huvu/t5_nemo2.0_finetune
branch
from
580f248
to
cf32841
Compare
huvunvidia
force-pushed
the
huvu/t5_nemo2.0_finetune
branch
from
a159120
to
87fe4b5
Compare
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
|
[🤖]: Hi @huvunvidia 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
|
LGTM |
JRD971000
approved these changes
Oct 10, 2024
ko3n1g
approved these changes
Oct 10, 2024
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* huvu/t5_nemo2.0 first commit from local * runable training * commit to save * update nemo/collections/llm/t5/data/pre_training.py, adding cicd test * updating codes * reset nemo/collections/nlp/parts/megatron_trainer_builder.py * reset megatron_lm_encoder_decoder_model.py, remove t5_release_test_config.sh * update init files * update Dockerfile.ci * fix wandb for cicd test * update training data path * remove uninstall TE * update .github/workflows/cicd-main.yml, disable fused/flashAttn * adjusting val_check_interval for action ci-cd tests * restore .github/workflows/cicd-main.yml * update * update nemologger args * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * a checkpoint for NeMo 2.0 T5 finetune * moving NeMo 2.0 examples to tests * reorganizing files, putting examples files into tests * runs with matched NeMo 1.0 and NeMo 2.0 curve * fix tiny/irrelevant changes * update AutoResume resume_from_path * add pre-trained checkpoint to Azure's TestData, add CI-CD test * only run t5 finetune test * fix cicd test * restore cicd file * restore cicd file * restore cicd file * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com>
yashaswikarnati
pushed a commit
that referenced
this pull request
Oct 20, 2024
* huvu/t5_nemo2.0 first commit from local * runable training * commit to save * update nemo/collections/llm/t5/data/pre_training.py, adding cicd test * updating codes * reset nemo/collections/nlp/parts/megatron_trainer_builder.py * reset megatron_lm_encoder_decoder_model.py, remove t5_release_test_config.sh * update init files * update Dockerfile.ci * fix wandb for cicd test * update training data path * remove uninstall TE * update .github/workflows/cicd-main.yml, disable fused/flashAttn * adjusting val_check_interval for action ci-cd tests * restore .github/workflows/cicd-main.yml * update * update nemologger args * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * a checkpoint for NeMo 2.0 T5 finetune * moving NeMo 2.0 examples to tests * reorganizing files, putting examples files into tests * runs with matched NeMo 1.0 and NeMo 2.0 curve * fix tiny/irrelevant changes * update AutoResume resume_from_path * add pre-trained checkpoint to Azure's TestData, add CI-CD test * only run t5 finetune test * fix cicd test * restore cicd file * restore cicd file * restore cicd file * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com>
artbataev
added a commit
to artbataev/NeMo
that referenced
this pull request
Oct 22, 2024
* huvu/t5_nemo2.0 first commit from local * runable training * commit to save * update nemo/collections/llm/t5/data/pre_training.py, adding cicd test * updating codes * reset nemo/collections/nlp/parts/megatron_trainer_builder.py * reset megatron_lm_encoder_decoder_model.py, remove t5_release_test_config.sh * update init files * update Dockerfile.ci * fix wandb for cicd test * update training data path * remove uninstall TE * update .github/workflows/cicd-main.yml, disable fused/flashAttn * adjusting val_check_interval for action ci-cd tests * restore .github/workflows/cicd-main.yml * update * update nemologger args * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * a checkpoint for NeMo 2.0 T5 finetune * moving NeMo 2.0 examples to tests * reorganizing files, putting examples files into tests * runs with matched NeMo 1.0 and NeMo 2.0 curve * fix tiny/irrelevant changes * update AutoResume resume_from_path * add pre-trained checkpoint to Azure's TestData, add CI-CD test * only run t5 finetune test * fix cicd test * restore cicd file * restore cicd file * restore cicd file * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com>
akoumpa
pushed a commit
that referenced
this pull request
Oct 24, 2024
* huvu/t5_nemo2.0 first commit from local * runable training * commit to save * update nemo/collections/llm/t5/data/pre_training.py, adding cicd test * updating codes * reset nemo/collections/nlp/parts/megatron_trainer_builder.py * reset megatron_lm_encoder_decoder_model.py, remove t5_release_test_config.sh * update init files * update Dockerfile.ci * fix wandb for cicd test * update training data path * remove uninstall TE * update .github/workflows/cicd-main.yml, disable fused/flashAttn * adjusting val_check_interval for action ci-cd tests * restore .github/workflows/cicd-main.yml * update * update nemologger args * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * a checkpoint for NeMo 2.0 T5 finetune * moving NeMo 2.0 examples to tests * reorganizing files, putting examples files into tests * runs with matched NeMo 1.0 and NeMo 2.0 curve * fix tiny/irrelevant changes * update AutoResume resume_from_path * add pre-trained checkpoint to Azure's TestData, add CI-CD test * only run t5 finetune test * fix cicd test * restore cicd file * restore cicd file * restore cicd file * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* huvu/t5_nemo2.0 first commit from local * runable training * commit to save * update nemo/collections/llm/t5/data/pre_training.py, adding cicd test * updating codes * reset nemo/collections/nlp/parts/megatron_trainer_builder.py * reset megatron_lm_encoder_decoder_model.py, remove t5_release_test_config.sh * update init files * update Dockerfile.ci * fix wandb for cicd test * update training data path * remove uninstall TE * update .github/workflows/cicd-main.yml, disable fused/flashAttn * adjusting val_check_interval for action ci-cd tests * restore .github/workflows/cicd-main.yml * update * update nemologger args * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * a checkpoint for NeMo 2.0 T5 finetune * moving NeMo 2.0 examples to tests * reorganizing files, putting examples files into tests * runs with matched NeMo 1.0 and NeMo 2.0 curve * fix tiny/irrelevant changes * update AutoResume resume_from_path * add pre-trained checkpoint to Azure's TestData, add CI-CD test * only run t5 finetune test * fix cicd test * restore cicd file * restore cicd file * restore cicd file * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information