Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTQ via NeMo-Run CLI #10984

Merged
merged 15 commits into from
Nov 18, 2024
Merged

PTQ via NeMo-Run CLI #10984

merged 15 commits into from
Nov 18, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Oct 22, 2024

What does this PR do ?

Adding support for PTQ in nemo CLI.

Prerequisite: #10642.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

nemo llm ptq nemo_checkpoint=/models/Llama-3-70b \
  calib_tp=8 \
  export_config.inference_tensor_parallel=2 \
  export_config.path=/models/Llama-3-70b-FP8

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@janekl janekl force-pushed the jlasek/ptq_cli branch 2 times, most recently from 7964a8d to b2abcbe Compare October 23, 2024 11:13
nemo/collections/llm/api.py Outdated Show resolved Hide resolved
@janekl janekl changed the title PTQ via nemo CLI PTQ via NeMo-Run CLI Oct 30, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl added Run CICD and removed Run CICD labels Oct 30, 2024
Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl mentioned this pull request Nov 8, 2024
8 tasks
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
janekl and others added 2 commits November 8, 2024 12:19
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
@janekl janekl added the Run CICD label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl removed the Run CICD label Nov 18, 2024
Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@janekl janekl merged commit 956b54d into main Nov 18, 2024
168 of 169 checks passed
@janekl janekl deleted the jlasek/ptq_cli branch November 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants