Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nemo2 peft merge #11017
base: main
Are you sure you want to change the base?
nemo2 peft merge #11017
Changes from 20 commits
d2f9cf7
c527914
65e252d
f1e52ed
acd56b0
03c4ea0
5d86702
1740d5d
c8b3a40
31e0c0a
169656d
3071ed8
2615f89
50b45ce
933fadf
82a1c25
45bffef
45b5f88
dd38c32
a135a73
deeb74d
db7497f
3cc2965
9992509
75ea08e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is a little long, could you break it into multiple sub functions for readability?
maybe 1) setup trainer 2) load model 3) merge (this is already compartmentalized so no need to change this) 4) save weights