Don't use nvidia_torch_version until after None check #11309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
There was a crash when nvidia_torch_version came back as None because it was still being used before the None check.
Collection: [NLP]
Changelog
Fixed crash when NVIDIA_PYTORCH_VERSION is not set
Usage
Run a anything that exercises this code without NVIDIA_PYTORCH_VERSION set
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
@MaximumEntropy @thomasdhc (Not sure if I'm supposed to ping the whole NLP reviewer list)
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
This is a minor fix. No associated tests or documentation. I tried to keep it simple. Devs may prefer different logic (e.g. an extra none check before the official release check, move the is_official_release_version def inside the None check block, etc)