We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_set_window_size()
Hello there,
the warnings in check_set_window_size() introduced in #960 seem to trigger all the time even if the input is actually correct and is not modified:
>>> check_set_window_size("causal", (-1, 0)) /virtualenv/lib/python3.10/site-packages/transformer_engine/pytorch/attention.py:3051: UserWarning: window_size should be (-1, 0) or (>=0, 0) for attn_mask_type=causal warnings.warn( (-1, 0)
I think it might be more helpful if the warning is only issued if the input window size is actually modified.
Thanks for looking into this!
The text was updated successfully, but these errors were encountered:
See PR #1074.
Sorry, something went wrong.
cyanguwa
Successfully merging a pull request may close this issue.
Hello there,
the warnings in
check_set_window_size()
introduced in #960 seem to trigger all the time even if the input is actually correct and is not modified:I think it might be more helpful if the warning is only issued if the input window size is actually modified.
Thanks for looking into this!
The text was updated successfully, but these errors were encountered: