Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pytorch] Warnings in check_set_window_size() trigger always #1064

Closed
Marks101 opened this issue Jul 31, 2024 · 1 comment · Fixed by #1074
Closed

[Pytorch] Warnings in check_set_window_size() trigger always #1064

Marks101 opened this issue Jul 31, 2024 · 1 comment · Fixed by #1074
Assignees

Comments

@Marks101
Copy link
Contributor

Hello there,

the warnings in check_set_window_size() introduced in #960 seem to trigger all the time even if the input is actually correct and is not modified:

>>> check_set_window_size("causal", (-1, 0))
/virtualenv/lib/python3.10/site-packages/transformer_engine/pytorch/attention.py:3051: UserWarning: window_size should be (-1, 0) or (>=0, 0) for attn_mask_type=causal
  warnings.warn(
(-1, 0)

I think it might be more helpful if the warning is only issued if the input window size is actually modified.

Thanks for looking into this!

@cyanguwa
Copy link
Collaborator

cyanguwa commented Aug 5, 2024

See PR #1074.

@cyanguwa cyanguwa closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants