-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyTorch] Improve logging/messaging in attention #1074
Conversation
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
for more information, see https://pre-commit.ci
/te-ci pytorch |
Hi @cyanguwa, I just tested these changes and the logging is good now. Really great to have the possibility to enable logging for the attention backend selection now. This helps a lot! Thanks for processing this so super quick! :D |
@Marks101 No worries! Would you be able to test the changes related to |
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
I already tested the warnings as well. All good from our side 👍 |
/te-ci pytorch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR
logging
packagecheck_set_window_size
to avoid warning whenwindow_size
is within the correct rangeFixes #1064 and #1065.
Type of change
Changes
Please list the changes introduced in this PR:
logging
packagecheck_set_window_size
to avoid warning whenwindow_size
is within the correct rangeChecklist: