[PyTorch] Merge k_channels and v_channels back to kv_channels
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
/te-ci pytorch |
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
|
/te-ci pytorch |
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
|
/te-ci pytorch |
ptrendx
reviewed
Aug 12, 2024
ptrendx
approved these changes
Aug 13, 2024
mgoldfarb-nvidia
pushed a commit
to mgoldfarb-nvidia/TransformerEngine
that referenced
this pull request
Aug 14, 2024
…VIDIA#1094) * merge k_channels and v_channels back to kv_channels and accept a tuple Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix isinstance call Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> * fix MLA tests Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> --------- Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges
k_channelsandv_channelsback tokv_channelsinDotProductAttention.__init__()to avoid breaking backward compatibility, but it allows users to pass in a tuple(int, int)in MLA (multi-latent attention) cases.We will add support for MLA in
MultiHeadAttentionandTransformerLayerin future PRs.Type of change
Changes
Please list the changes introduced in this PR:
k_channelsandv_channelsback tokv_channelsinDotProductAttentionChecklist: