Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Activation operations #1164

Merged
merged 17 commits into from
Nov 15, 2024
Merged

[PyTorch] Activation operations #1164

merged 17 commits into from
Nov 15, 2024

Conversation

timmoon10
Copy link
Collaborator

Description

This PR extends the operation-based API (see #707) with activation functions like ReLU, GELU, and SwiGLU.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Add ReLU, GELU, ReGLU, GEGLU, SwiGLU operations

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

timmoon10 and others added 2 commits September 5, 2024 19:29
@timmoon10
Add activation ops
5a35550 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6b7b69f 
for more information, see https://pre-commit.ci
@timmoon10 timmoon10 marked this pull request as ready for review September 6, 2024 19:39
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10 timmoon10 mentioned this pull request Sep 6, 2024
Closed
13 tasks
@timmoon10
Fix lint warnings
cf36606 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10 and others added 5 commits September 9, 2024 14:44
@timmoon10
Fix linter warning
9fc61dc 
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
@timmoon10
Merge branch 'main' into activation-ops
996ffed
@timmoon10
Update to use QuantizedTensor
c0f6101 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10
Merge branch 'main' into activation-ops
9e07b9b
@timmoon10
Respect PyTorch autograd dtype
099508d 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10
Copy link
Collaborator Author

Merging with approval from @ptrendx and @ksivaman.

@timmoon10 timmoon10 merged commit 20b0473 into NVIDIA:main Nov 15, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmoon10 @ksivaman