Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Improve get_qkv_layout #1214

Merged
merged 6 commits into from
Oct 9, 2024
Merged

[PyTorch] Improve get_qkv_layout #1214

merged 6 commits into from
Oct 9, 2024

Conversation

cyanguwa
Copy link
Collaborator

@cyanguwa cyanguwa commented Sep 27, 2024 •
edited
Loading

Description

This PR improves the get_qkv_layout() logic.

Fixes #1195

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Improves get_qkv_layout function.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

cyanguwa and others added 2 commits September 27, 2024 16:05
@cyanguwa
improve get_attention_backend logic
4b0ce23 
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e5635ce 
for more information, see https://pre-commit.ci
@cyanguwa cyanguwa mentioned this pull request Sep 27, 2024
Closed
@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch

cyanguwa and others added 2 commits September 30, 2024 14:37
@cyanguwa
polish logic and wording
0dd2390 
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8d238c0 
for more information, see https://pre-commit.ci
@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch

@cyanguwa
remove redundant comment
71e2590 
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch

@cyanguwa cyanguwa requested a review from ksivaman October 1, 2024 16:29
@cyanguwa cyanguwa changed the title [PyTorch] Improve get_attention_backend [PyTorch] Improve get_qkv_layout Oct 9, 2024
ksivaman
ksivaman approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanguwa cyanguwa merged commit 5b6546c into NVIDIA:main Oct 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksivaman ksivaman ksivaman approved these changes

@ptrendx ptrendx Awaiting requested review from ptrendx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PyTorch] fused CUDNN attention kernel not properly handling strides
2 participants
@cyanguwa @ksivaman