Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAX] Add back the xla deterministic flag #1301

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

zlsh80826
Copy link
Collaborator

Description

There was a segfault issue on XLA, so we temporary disabled the deterministic flag in #1262. XLA recently fixed the issue in openxla/xla#18766, so it is good to add back that flag now.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Add --xla_gpu_deterministic_ops to have run-to-run deterministic to have the stable CI results

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@zlsh80826
Copy link
Collaborator Author

/te-ci jax

@phu0ngng
Copy link
Collaborator

/te-ci jax

Signed-off-by: Reese Wang <rewang@nvidia.com>
@zlsh80826 zlsh80826 force-pushed the rewang/revert-deterministic-tests branch from af4983a to bbc263c Compare November 6, 2024 03:08
@zlsh80826
Copy link
Collaborator Author

/te-ci jax L1

@phu0ngng
Copy link
Collaborator

phu0ngng commented Nov 6, 2024

Pipeline #20118954, all tests passed.

@phu0ngng phu0ngng merged commit d4aa299 into NVIDIA:main Nov 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants