Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with uv instead of just pip #1324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Build with uv instead of just pip #1324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e821d5a
Build with uv instead of pip
jennifgcrl Nov 8, 2024
4170941
revert to just uninstall_te_wheel_packages change
jennifgcrl Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions build_tools/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from pathlib import Path
from subprocess import CalledProcessError
from typing import List, Optional, Tuple, Union
from importlib.util import find_spec


@functools.lru_cache(maxsize=None)
Expand Down Expand Up @@ -302,16 +303,17 @@ def install_and_import(package):


def uninstall_te_wheel_packages():
subprocess.check_call(
[
sys.executable,
"-m",
"pip",
"uninstall",
"-y",
"transformer_engine_cu12",
"transformer_engine_torch",
"transformer_engine_paddle",
"transformer_engine_jax",
]
)
if find_spec("pip") is not None:
subprocess.check_call(
[
sys.executable,
"-m",
"pip",
"uninstall",
"-y",
"transformer_engine_cu12",
"transformer_engine_torch",
"transformer_engine_paddle",
"transformer_engine_jax",
]
)
Comment on lines 305 to +319
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable change that I would accept on its own. It doesn't fully solve the root issue (the package structure is different when installing from PyPI or from source), so I could imagine users running into problems if they install TE multiple times. But it seems fair to expect users to handle this on their own if they are using a non-standard build environment.