Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR #1333

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kmaehashi
Copy link
Contributor

Description

Calculate the path to cudnn-frontend as a relative path from transformer_engine/common/CMakeLists.txt, rather than a relative path from the directory specified to the cmake command.

This will allow other CMake projects to use TransformerEngine as a sub-project (e.g., by adding add_subdirectory(third_party/TransformerEngine/transformer_engine/common) in their CMakeLists.txt) to build TransformerEngine as a part of their build.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR
  • Display CUDNN_FRONTEND_INCLUDE_DIR on error

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kenichi Maehashi <webmaster@kenichimaehashi.com>
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting this.

@timmoon10 timmoon10 merged commit 994f19d into NVIDIA:main Nov 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants