This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue by replacing
__launch_bounds__
usages withCUB_DETAIL_LAUNCH_BOUNDS
.CUB_DETAIL_LAUNCH_BOUNDS
leads to__launch_bounds__
usage only when RDC is not specified. Builds without RDC are not affected by this PR. For builds with RDC, the max performance differences are:Negative diff means speedup of the version without
__launch_bounds__
. Since the results are quite controversial, I wouldn't like to advertise the macro as our API. If absolutely needed, one might define:But for now it's an implementation detail that fixes compilation with RDC in some corner cases. Going forward, we might consider having tuning API that would control
__launch_bounds__
specification as well as pragma unroll usage. The default tuning would be a function of the input types.