Update quake-dialect.md #1760
Open
Update quake-dialect.md #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo: replaced "Quake's memory model" with "QTX's memory model"
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
cuda-quantum-bot
added a commit
that referenced
this pull request
Jun 5, 2024
|
recheck |
amccaskey
reviewed
Jun 6, 2024
| @@ -28,7 +28,7 @@ greater, the extra qubits are considered controls. | |||
| The main motivation behind Quake's value model is to directly expose | |||
| quantum and classical data dependencies for optimization purposes, | |||
| i.e., to represent the dataflow in quantum computations. In contrast | |||
| to Quake's memory model, which uses memory semantics (quantum | |||
There was a problem hiding this comment.
Quake is flexible in that it can represent both the memory and value semantics model (switching via the --memtoreg pass). So the text as-is is correct. Granted, the whole document here could use a refresh probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typo: replaced "Quake's memory model" with "QTX's memory model"
Description
Fixed typo: replaced "Quake's memory model" with "QTX's memory model" (previously incorrectly stated as "Quake's memory model").