Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a strong validation for qubit allocation batching #1797

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Add a strong validation for qubit allocation batching #1797

merged 6 commits into from
Jul 25, 2024

Conversation

1tnguyen
Copy link
Collaborator

Description

The simulator expects linear state expansion (incremental qubit indices) for these allocateQubits calls.
Hence, add a validation check in the DefaultExecutionManager, i.e., the one for simulator backends.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@cuda-quantum-bot
Docs preview for PR #1797.
86846ac
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
@cuda-quantum-bot
Docs preview for PR #1797.
82d3fbf
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@cuda-quantum-bot
Docs preview for PR #1797.
e6aae75
bmhowe23
bmhowe23 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR may have slipped through the cracks (or perhaps it was overridden by another PR?). In any case, assuming it merges cleanly, it is still wanted, and the final tests run correctly, it looks good to me.

@1tnguyen
Copy link
Collaborator Author

Looks like this PR may have slipped through the cracks (or perhaps it was overridden by another PR?). In any case, assuming it merges cleanly, it is still wanted, and the final tests run correctly, it looks good to me.

Thanks, Ben!
Indeed, it slipped through the cracks. This was to address a post-merge comment for the state handling work.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@cuda-quantum-bot
Docs preview for PR #1797.
e6e5fc6
@1tnguyen 1tnguyen enabled auto-merge (squash) July 25, 2024 04:26
@1tnguyen 1tnguyen merged commit cd69ac5 into NVIDIA:main Jul 25, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@bettinaheim bettinaheim added this to the release 0.8.0 milestone Jul 29, 2024
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

Assignees
No one assigned
Labels
no release notes Don't list this PR in the release notes
Projects
None yet
Milestone
release 0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1tnguyen @bmhowe23 @bettinaheim