Refactor github.actor to replace 'fixed' strings and add context checks of buildx for sequential compilation and partial failures scenario #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, the github.actor is required in workflows other than those involving fixed string.
Additionally, when using a linux-amd64-cpu8 for parallel workflows, it is necessary to include a step to check the context for buildx.
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
cuda-quantum-bot
added a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor github.actor:
Replace 'fixed' strings with the more flexible github.actor. This change ensures that workflows accommodate any general actor who forks the repository and utilizes GitHub Actions, rather than being limited to fixed string values.
Context Checks for Buildx:
Implement context checks in the buildx step, especially when using a single linux-xxx-cpu8 for parallel workflows. This ensures the build context is correctly validated, addressing potential issues in sequential compilation and scenarios where partial failures might occur.