Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Enhancements to the custom operations feature #1968

Merged
merged 3 commits into from
Jul 21, 2024
Merged

[Python] Enhancements to the custom operations feature #1968

merged 3 commits into from
Jul 21, 2024

Conversation

khalatepradnya
Copy link
Collaborator

  • Allow users to specify unitary as np.matrix, 2D array
  • Make custom operations available to look up by name in the builder mode via attribute getter

@khalatepradnya khalatepradnya self-assigned this Jul 19, 2024
@khalatepradnya khalatepradnya added the python-lang Anything related to the Python CUDA Quantum language implementation label Jul 19, 2024
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@cuda-quantum-bot
Docs preview for PR #1968.
b5b4ae8
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@cuda-quantum-bot
Docs preview for PR #1968.
1cc694f
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@cuda-quantum-bot
Docs preview for PR #1968.
516f08b
@khalatepradnya khalatepradnya enabled auto-merge (squash) July 19, 2024 20:15
@khalatepradnya khalatepradnya enabled auto-merge (squash) July 19, 2024 20:16
sacpis
sacpis approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A few changes. Thanks @khalatepradnya!

@khalatepradnya
* Enhancements to the custom operations feature
f273d8c 
  -- accept np.matrix, 2D arrays
  -- make custom operations avaiable to look up by name in the builder
mode via attribute getter
@khalatepradnya
* Use regex for the matrix contents since the multiplication results can
228713f 
  vary by 1e-6.
@khalatepradnya
* Addressing review comment.
27a689d
@khalatepradnya khalatepradnya enabled auto-merge (squash) July 21, 2024 17:53
@khalatepradnya khalatepradnya merged commit 79d0c06 into NVIDIA:main Jul 21, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2024
@khalatepradnya khalatepradnya deleted the find_custom_op_by_name branch July 22, 2024 18:19
@bettinaheim bettinaheim added this to the release 0.8.0 milestone Jul 29, 2024
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sacpis sacpis sacpis approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

@annagrin annagrin Awaiting requested review from annagrin

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees

@khalatepradnya khalatepradnya

Labels
no release notes Don't list this PR in the release notes python-lang Anything related to the Python CUDA Quantum language implementation
Projects
None yet
Milestone
release 0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@khalatepradnya @sacpis @bettinaheim