[NVQC] Support direct kernel invocation with a return value #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1tnguyen
requested review from
bettinaheim,
amccaskey and
bmhowe23
as code owners
schweitzpgi
reviewed
Jul 19, 2024
schweitzpgi
reviewed
Jul 19, 2024
runtime/cudaq/platform/default/rest_server/helpers/RestRemoteServer.cpp
Outdated
Show resolved
Hide resolved
runtime/cudaq/platform/default/rest_server/helpers/RestRemoteServer.cpp
Outdated
Show resolved
Hide resolved
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
…erver.cpp Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
…erver.cpp Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
reviewed
Jul 19, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Jul 24, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For MLIR-based kernels, the kernel launch is bootstrapped; hence technically we can pack the return value back to users.
This PR enables that:
Add a flat-buffer in
ExecutionContextto store this data.Server side: introspect the entry-point kernel IR to know what type is being return. In this PR, only simple data types (float/int/bool) are supported.
Client side: check if buffer data is being returned from the server and the kernel launch is expecting some return value (via the return offset). If so, copy the data to return to users.
Adds tests for supported return types.
Compatibility
This is not a breaking change.
When both the client and service are updated, the return value will be available. Otherwise, no return value would be available (same as the existing behavior)
New client - old service: the service won't populate the buffer field in the return JSON.
Old client - new service: the buffer field in the return JSON would be dropped/ignored by the client.
Resolved #1597