-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hadamard test tutorial #1972
Conversation
I am fine with the modification. Looks good to me. I recommend to keep the matrix diagonalization example (I am aware that it is one of the Hadamard test application). The goal of this application is to to show an example for the nvidia-mQpu backend. In chemistry, the quantum filter diagonalization (Hadamrd test type) can be use to build the matrix element of the Hamiltonian and the wavefunction overlap, then we use classical algorithm to diagonalize the matrix. |
Thank you. I'll revert the diagonalization part and modify it. |
Sorry. I didn't understand what you meant by diagonalizing random expectations in a matrix. It might make sense if the parameters were correlated, but that would be a generalized eigenvalue problem, which would be more complicated. At any rate, I went back to computing the expectation values in parallel. I believe I have included what we want in this notebook. |
@ikkoham Notebook looks good to me. |
Thank you. I believe this PR is mergeable now. |
Command Bot: Processing... |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
I'd like to suggest some points.
@
instead of np.dot.@marwafar Feel free to comment on this PR.