Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][NFC] Move target config tests to targettests directory #1973

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

1tnguyen
Copy link
Collaborator

Description

These tests, despite not doing any execution, are 'target'-related and, hence are now relocated to the targettests directory.

The one that performs compilations for all targets in both library and mlir mode is a slow test.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

My only question is whether these tests can and ought to be run even though they aren't being run. Running them would provide more test coverage obviously.

@1tnguyen
Copy link
Collaborator Author

LGTM.

My only question is whether these tests can and ought to be run even though they aren't being run. Running them would provide more test coverage obviously.

They will be run in the CI, just not under the 'test' umbrella, which we prefer to be really quick :-)

@1tnguyen 1tnguyen enabled auto-merge (squash) July 22, 2024 23:02
@1tnguyen 1tnguyen merged commit 2b38d2c into NVIDIA:main Jul 23, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
@bettinaheim bettinaheim added the maintenance Work items to update and improve the code base label Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Work items to update and improve the code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants