[C++ bridge] Switch from using arith ops to cc.cast #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arith dialect provides a big menu of casting/conversion operations that we can use but which have their own rules and semantics. For example, the generation of a quantum circuit can involve aggressive constant propagation. By using an operation in a dialect we control (CC), we can implement folding and combing these operations in ways that are suitable to our domain and do not rely on decisions in the MLIR code that may be too conservative or too aggressive for our needs. [core] Add constant folding of cc.cast operations. These constant folding operations will eliminate cc.cast operations when they are converting the type of a constant input op. Update the tests. Add pattern to eliminate integer casts into an integer comparison. Add constant folding of complex.create. Apparently MLIR doesn't do this. Add cast complex to complex and various constant foldings. Add a new test. Add codegen expansion pattern.
annagrin
reviewed
Jul 20, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arith dialect provides a big menu of casting/conversion operations that we can use but which have their own rules and semantics. For example, the generation of a quantum circuit can involve aggressive constant propagation. By using an operation in a dialect we control (CC), we can implement folding and combing these operations in ways that are suitable to our domain and do not rely on decisions in the MLIR code that may be too conservative or too aggressive for our needs.
[core] Add constant folding of cc.cast operations.
These constant folding operations will eliminate cc.cast operations when they are converting the type of a constant input op.
Update the tests.
Add pattern to eliminate integer casts into an integer comparison.
Add constant folding of complex.create. Apparently MLIR doesn't do this.
Add cast complex to complex and various constant foldings.
Add a new test.
Add codegen expansion pattern.
Description