Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clifford-only simulator (Stim) #2193

Merged
merged 12 commits into from
Sep 12, 2024
Merged

Conversation

bmhowe23
Copy link
Collaborator

@bmhowe23 bmhowe23 commented Sep 6, 2024

Add https://github.com/quantumlib/Stim (v1.13.0) simulator for Clifford-only circuits.

The user requests it like other targets: --target stim and cudaq.set_target('stim').

github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@bmhowe23 bmhowe23 marked this pull request as ready for review September 10, 2024 14:07
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! Thanks, Ben.
I don't see any new tests... It seems all of the C++ tests will be run except the ones which are skipped with #ifndef CUDAQ_BACKEND_STIM. What about Python - may be we should add a couple which showcase which gates are supported and behavior on unsupported gates.

Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

* Add Python tests (with negative tests)
* Throw an addition error message
* Add TODO
@bmhowe23
Copy link
Collaborator Author

These changes look great! Thanks, Ben. I don't see any new tests... It seems all of the C++ tests will be run except the ones which are skipped with #ifndef CUDAQ_BACKEND_STIM. What about Python - may be we should add a couple which showcase which gates are supported and behavior on unsupported gates.

Thanks for the suggestion, Pradnya. I added some Stim-specific backend tests in 20343fd. Please take a look and let me know if that's what you had in mind, or if you'd like to see something else, too.

Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
bmhowe23 and others added 2 commits September 11, 2024 14:21
* Reduce the number of files built to only those needed by libstim. This
  makes the build go a little bit faster.
* Remove warnings when compiling libstim to not clutter up console
* Make the warning custimizations ONLY applicable to Stim submodule
  building (i.e. allow regular warnings/errors in
  StimCircuitSimulator.cpp)
* Remove unneeded macro
@bmhowe23 bmhowe23 enabled auto-merge (squash) September 11, 2024 20:19
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@bmhowe23 bmhowe23 merged commit 70d00f3 into NVIDIA:main Sep 12, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@bmhowe23 bmhowe23 deleted the pr-add-stim-backend branch September 12, 2024 03:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants