-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ngc signing job for auto signing #8
Open
shivakunv
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
shivakunv:ngc_signing_job
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Jul 2, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 4, 2024 10:27
0923a2e
to
cfd59fb
Compare
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 4, 2024 10:43
cfd59fb
to
2b12e7a
Compare
elezar
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @shivakunv.
I think we need some minor fixes to cover all the images that we SHOULD be producing.
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 4, 2024 15:14
c24ea52
to
78561c7
Compare
Please refer for sign jobs: https://gitlab-master.nvidia.com/dl/container-dev/cuda-sample-images/-/merge_requests/1 |
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 4, 2024 15:32
78561c7
to
dbac40b
Compare
elezar
requested changes
Jul 17, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 17, 2024 12:20
dbac40b
to
70c460e
Compare
elezar
reviewed
Jul 31, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 31, 2024 14:47
70c460e
to
e26d3f7
Compare
Signed-off-by: shiva kumar <shivaku@nvidia.com>
shivakunv
force-pushed
the
ngc_signing_job
branch
from
July 31, 2024 14:49
e26d3f7
to
48bbea8
Compare
@elezar PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @elezar @cdesiniotis