Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation party #710

Merged
1 commit merged into from
Apr 18, 2019
Merged

Documentation party #710

1 commit merged into from
Apr 18, 2019

Conversation

allthesignals
Copy link
Collaborator

This PR adds more documentation to the app. It still needs a lot more documentation, specifically in w/r/t the rows.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #710 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #710      +/-   ##
===========================================
+ Coverage    42.88%   42.95%   +0.07%     
===========================================
  Files           61       61              
  Lines         1145     1143       -2     
===========================================
  Hits           491      491              
+ Misses         654      652       -2
Impacted Files Coverage Δ
app/routes/profile/social.js 100% <ø> (ø) ⬆️
app/routes/profile/census.js 100% <ø> (ø) ⬆️
app/routes/profile.js 100% <ø> (ø) ⬆️
app/routes/profile/economic.js 100% <ø> (ø) ⬆️
app/routes/profile/housing.js 100% <ø> (ø) ⬆️
app/models/row.js 100% <ø> (+22.22%) ⬆️
app/routes/index.js 100% <ø> (ø) ⬆️
app/routes/data.js 0% <ø> (ø) ⬆️
app/mixins/downloadable.js 100% <ø> (ø) ⬆️
app/routes/profile/index.js 0% <ø> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b7c2e...5e5894d. Read the comment docs.

app/models/row.js Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LAV THIS!! added a few clarifying questions. TY TY TY SM!

app/models/row.js Outdated Show resolved Hide resolved
app/routes/data.js Show resolved Hide resolved
app/routes/index.js Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase & squash them commits and this is GOOD 2 GO!

@ghost ghost merged commit 5e99e4e into develop Apr 18, 2019
@ghost ghost removed the in progress label Apr 18, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant