Skip to content

Commit

Permalink
Remove CI support for Open eBooks
Browse files Browse the repository at this point in the history
  • Loading branch information
ettore committed May 7, 2024
1 parent f08b793 commit 53083b0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 51 deletions.
37 changes: 3 additions & 34 deletions .github/workflows/archive-and-upload.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: SimplyE and Open eBooks Build
name: SimplyE Build
on:
push:
branches:
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
upload-arc:
runs-on: macOS-13
needs: version-check
if: needs.version-check.outputs.simplye_changed == '1' || needs.version-check.outputs.openebooks_changed == '1'
if: needs.version-check.outputs.simplye_changed == '1'
env:
GITHUB_TOKEN: ${{ secrets.IOS_DEV_CI_PAT }}
steps:
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
repository: NYPL-Simplified/DRM-iOS-AdeptConnector
token: ${{ secrets.IOS_DEV_CI_PAT }}
path: ./DRM-iOS-AdeptConnector
- name: Setup SimplyE and Open eBooks Distribution Details
- name: Setup SimplyE Distribution Details
run: ./scripts/decode-install-secrets.sh
env:
BUILD_CONTEXT: ci
Expand Down Expand Up @@ -135,34 +135,3 @@ jobs:
FASTLANE_PASSWORD: ${{ secrets.APPLEID_PASSWORD }}
FASTLANE_SESSION: ${{ secrets.FASTLANE_SESSION }}
FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: ${{ secrets.APPLEID_APP_SPECIFIC_PASSWORD }}

- name: Archive Open eBooks
if: needs.version-check.outputs.openebooks_changed == '1'
run: ./scripts/xcode-archive.sh openebooks
env:
BUILD_CONTEXT: ci
- name: Export Open eBooks for Ad Hoc
if: needs.version-check.outputs.openebooks_changed == '1'
run: ./scripts/xcode-export-adhoc.sh openebooks
env:
BUILD_CONTEXT: ci
- name: Upload Open eBooks to Firebase
if: needs.version-check.outputs.openebooks_changed == '1'
run: ./scripts/firebase-upload.sh openebooks
env:
BUILD_CONTEXT: ci
- name: Export Open eBooks for App Store
if: needs.version-check.outputs.openebooks_changed == '1' && startsWith(github.ref, 'refs/heads/release/')
run: ./scripts/xcode-export-appstore.sh openebooks
env:
BUILD_CONTEXT: ci
- name: Upload Open eBooks to TestFlight
if: needs.version-check.outputs.openebooks_changed == '1' && startsWith(github.ref, 'refs/heads/release/')
run: ./scripts/testflight-upload.sh openebooks
env:
BUILD_CONTEXT: ci
IOS_DISTR_IDENTITY_PASSPHRASE: ${{ secrets.IOS_DISTR_IDENTITY_PASSPHRASE }}
FASTLANE_USER: ${{ secrets.APPLEID_USERNAME }}
FASTLANE_PASSWORD: ${{ secrets.APPLEID_PASSWORD }}
FASTLANE_SESSION: ${{ secrets.FASTLANE_SESSION }}
FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: ${{ secrets.APPLEID_APP_SPECIFIC_PASSWORD }}
4 changes: 0 additions & 4 deletions .github/workflows/unit-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,3 @@ jobs:
run: ./scripts/xcode-test.sh simplye
env:
BUILD_CONTEXT: ci
# - name: Run Open eBooks tests
# run: ./scripts/xcode-test.sh openebooks
# env:
# BUILD_CONTEXT: ci
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
[![SimplyE and Open eBooks Build](https://github.com/NYPL-Simplified/Simplified-iOS/workflows/SimplyE%20and%20Open%20eBooks%20Build/badge.svg)](https://github.com/NYPL-Simplified/Simplified-iOS/actions?query=workflow%3A%22SimplyE%20and%20Open%20eBooks%20Build%22) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
[![SimplyE Build](https://github.com/NYPL-Simplified/Simplified-iOS/workflows/SimplyE%20Build/badge.svg)](https://github.com/NYPL-Simplified/Simplified-iOS/actions?query=workflow%3A%22SimplyE%20Build%22) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

# SimplyE and Open eBooks

This repo contains the client-side code for the New York Public Library's [SimplyE](https://www.nypl.org/books-music-movies/ebookcentral/simplye) and [Open eBooks](https://openebooks.net) apps.

The 2 apps share most of the code base. App-specific source files will have a `SE` / `OE` prefix or suffix, while configuration files reside in the `SimplyE` and `OpenEbooks` directories at the root of the repo.

Consequently, [releases](https://github.com/NYPL-Simplified/Simplified-iOS/releases) in this repo track both apps. However, you won't see any Open eBooks versions before 1.9.0 because historically Open eBooks lived in a separate repo. Releases that lack an app specifier, i.e. any version such as v3.6.1 and earlier, are SimplyE releases.
Consequently, [releases](https://github.com/NYPL-Simplified/Simplified-iOS/releases) in this repo track both apps. However, you won't see any Open eBooks versions before 1.9.0 because historically Open eBooks lived in a separate repo. You also won't see Open eBooks releases after 2.5.1, because Open eBooks development has been moved to a different repo. Releases that lack an app specifier, i.e. any version such as v3.6.1 and earlier, are SimplyE releases.

# System Requirements

- Install Xcode 14.3.1 in `/Applications`, open it and make sure to install additional components if it asks you.
- Install Xcode 15.0.1 in `/Applications`, open it and make sure to install additional components if it asks you.
- Install [Carthage](https://github.com/Carthage/Carthage) 0.38 or newer if you haven't already. Using `brew` is recommended.

# Building without DRM support
Expand Down Expand Up @@ -58,7 +58,7 @@ The `scripts` directory contains a number of other scripts to build dependencies

Open eBooks is an app primarily targeted toward the education space. It requires DRM. Follow the same steps as indicated above and use the "Open eBooks" Xcode target.

NOTE: the Open eBooks target needs to be upgraded to match SimplyE's.
NOTE: *OPEN EBOOKS IS NO LONGER SUPPORTED IN THIS REPO.*

# Contributing

Expand All @@ -78,11 +78,11 @@ Release branch names follow the convention: `release/simplye/<version>` or `rele

Feature branch names (for features whose development is a month or more): `feature/<feature-name>`, e.g. `feature/my-new-screen`.

[Continuous integration](https://github.com/NYPL-Simplified/Simplified/wiki/iOS-CI-CD) is enabled on push events on `develop`, release and feature branches. SimplyE and Open eBooks device builds are uploaded to Firebase and, for release builds, also to TestFlight.
[Continuous integration](https://github.com/NYPL-Simplified/Simplified/wiki/iOS-CI-CD) is enabled on push events on `develop`, release and feature branches. SimplyE device builds are uploaded to Firebase and, for release builds, also to TestFlight. *CI no longer builds Open eBooks.*

# License

Copyright © 2015-2023 The New York Public Library, Astor, Lenox, and Tilden Foundations
Copyright © 2015-2024 The New York Public Library, Astor, Lenox, and Tilden Foundations

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
7 changes: 0 additions & 7 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,5 @@ platform :ios do
app_identifier: "org.nypl.labs.SimplyE",
adhoc: "true"
)
sigh(
app_identifier: "org.nypl.labs.OpenEbooks"
)
sigh(
app_identifier: "org.nypl.labs.OpenEbooks",
adhoc: "true"
)
end
end

0 comments on commit 53083b0

Please sign in to comment.