Skip to content

Commit

Permalink
Merge pull request #1626 from NYPL-Simplified/iOS-584
Browse files Browse the repository at this point in the history
iOS-584 Disable ipa upload to firebase
  • Loading branch information
ExplorerNautilus authored Nov 8, 2023
2 parents 22f7d20 + 8d3abf8 commit 8183fb6
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions scripts/firebase-upload.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@ else
fatal "Unable to upload to firebase: missing ad-hoc export!"
fi

# Disabling the IPA upload to firebase because we encountered authentication error,
# possibly due to `token` authentication is deprecated.
# upload app binary
echo "Using ipa at $IPA_PATH"
firebase appdistribution:distribute \
--token "${FIREBASE_TOKEN}" \
--app "${FIREBASE_APP_ID}" \
"${IPA_PATH}"
#echo "Using ipa at $IPA_PATH"
#firebase appdistribution:distribute \
# --token "${FIREBASE_TOKEN}" \
# --app "${FIREBASE_APP_ID}" \
# "${IPA_PATH}"

# upload symbols
./scripts/firebase-upload-symbols.sh "$APPNAME_PARAM" "$DSYMS_PATH"
Expand Down

0 comments on commit 8183fb6

Please sign in to comment.