Merge SimplyE 3.9.5 release #1630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update ZXingObjC to a fork that includes fixes for Xcode 14.3 and min deployment target: old project was supporting down to iOS 8, but current Xcode only supports down to iOS 11.
Also remove dSYM push to Crashlytics from no-drm build
IOS-583 / IOS-567 Upgrade tooling to Xcode 14.3
The switch from `PublicationServer` to `GCDHTTPServer` in Readium 2.5.0 caused some regressions when browsing ePubs with VoiceOver: - rendering issues while browsing (swift L/R) when scroll mode is not set - no automatic scroll when continuous reading mode is enabled. This silences the many deprecation warnings that are now emitted while still using the old PublicationServer. It also fixes a few other Xcode 14.3 warnings.
iOS-584 Disable ipa upload to firebase
…ired banned books
iOS-586 Implement logic to add expiration date to banned books and remove expired banned books
|
closing because of weird conflicts. Will do this on command line since merge runs smoothly there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Merges latest 3.9.5 release to master. This includes:
Why are we doing this? (w/ JIRA link if applicable)
Part of our release process
Dependencies for merging? Releasing to production?
We already released 3.9.5 to the App Store.