-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule Forced Host and Service Notifications and Event Handlers #966
Open
nagiosgwesterman
wants to merge
26
commits into
master
Choose a base branch
from
gw-force-run
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for practice atm)
…TION in handle_async_host_check_result
…both CHECK_OPTION_FORCE_EXECUTION and CHECK_OPTION_FORCED_NOTIFICATION
…_service_check_result
…RCED_SVC_NOTIFICATION and added conditional
… SCHEDULE_FORCED_SVC_NOTIFICATION
…_FORCED_SVC_EVENT_HANDLER to commands.c
… to send CHECK_OPTION_FORCE_EVENT_HANDLER in commands.c
…nc_host/service_check_result
… schedule_host/service_check and added CMD_SCHEDULE_FORCED_HOST_EVENT_HANDLER to valid host verification check
@tsadpbb would you please review? |
So the way I understand it, you are scheduling a new check with the option to make the notification/event handler forced. I would rather you add something to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For internal reviewers, these are the actual feature requests: here and here.
IMPLEMENTATION
CHECK_OPTION_FORCE_NOTIFICATION
andCHECK_OPTION_FORCE_EVENT_HANDLER
. When the check result is processed, it checks for these options and reacts accordingly.TESTING PLAN
SCHEDULE_FORCED_HOST_NOTIFICATION
SCHEDULE_FORCED_SVC_NOTIFICATION
SCHEDULE_FORCED_HOST_EVENT_HANDLER
SCHEDULE_FORCED_SVC_EVENT_HANDLER
These require some setup to test (including setting up event handlers). Here are some docs to help with that:
[1] Example external command
[2] List of external commands
[3] Setting up event handlers
Please also check for code quality and any functional flaws in my prospective changes. There is a solid chance this is nowhere near to what was requested or is otherwise terrible. I learned a lot and that's what life is all about isn't it?