-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: x parity constraints for eigenmodes #1139
Open
danielwboyce
wants to merge
16
commits into
NanoComp:master
Choose a base branch
from
danielwboyce:iss_1109
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o figure out how to rotate the fields object f
The |
…alues to by d-Y or d-Z based on coordcycle value
… recasting should be in order. Need to rotate parity bitfield
At the moment when I run
|
Actually judging the error to be caused by SWIG seems a bit hasty; I'm just not quite sure what's caused it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1109.
In process of making changes to cyclically rotate Meep's coordinate systems when passed into MPB so that wave propagation is always in the x direction. So of the math involved and its implementation (notation) is a bit opaque, so at the moment the largest part of the problem is understanding what exactly is happening in the
src/mpb.cpp
so I don't miss any necessary transformations, either from Meep to MPB or from MPB to Meep.